fix(codegen): required param error implementation

discord-gophers / goapi-gen

This package contains a set of utilities for generating Go boilerplate code for services based on OpenAPI 3.0 API definitions

Apache License 2.0

137 stars 12 forks source link

Closed Karitham closed 2 years ago

Karitham commented 2 years ago

return correctly required param
delete dead code
replace usage of deprecated function
update go:generate command of moq to use latest, since it seems to be causing issues.
update required param error tests

POSSIBLE BREAKING: multiple word call to title helper function (no change in generation, and it generates valid code, but to be aware if needs be).

diamondburned commented 2 years ago

I created PR https://github.com/discord-gophers/goapi-gen/pull/85 which depends on this PR before it can be merged (or the other PR gets merged into this PR).

Karitham commented 2 years ago

Waiting for review from other maintainer before merging this one. Will be merging both then