Fix broken link to logging page, inconsistent post-setup instructions, ordered list numbering

discord-jda / JDA-Website

Source for the JDA Wiki Website

https://jda.wiki

Apache License 2.0

11 stars 19 forks source link

Fix broken link to logging page, inconsistent post-setup instructions, ordered list numbering #15

Closed CheesyGamer77 closed 2 years ago

CheesyGamer77 commented 2 years ago

This PR fixes the following: 1) Broken hyperlink to logging setup page under IntelliJ setup page (Closes #14) 2) Inconsistent post-setup instructions. There were several different ways that the setup pages were advising users on what to do next. This PR unifies these instructions by using the post-setup instructions under the IntelliJ setup page. 3) Ordered list numbering under eclipse setup page.

hexillium1 commented 2 years ago

I think we should prefer to use numbering that mkdocs will transform into the 'real' numbers, like:

1. First item
1. Second item
1. Third item

as it makes re-ordering or editing the lists a lot easier, and these will still be rendered into a normal ordered list with correct numbering

CheesyGamer77 commented 2 years ago

Above commit was me syncing this PR to latest commit. Not sure if anything else needs to be done in the meantime

MinnDevelopment commented 2 years ago

Why does this PR cover 3 different things? Please avoid scope creep like that.

CheesyGamer77 commented 2 years ago

Why does this PR cover 3 different things? Please avoid scope creep like that.

Sorry about that. This was my first PR in a public repo after learning git so I'm still relatively new to the github workflow. I'll be sure to keep this in mind for the future