search

discord-jda / JDA-Website

Source for the JDA Wiki Website
https://jda.wiki
Apache License 2.0
11 stars 19 forks source link

Make deploy preview concurrency safe. #37

Closed Andre601 closed 1 year ago

Andre601 commented 2 years ago

Minor fix to the deploy preview action to make sure that only one action instance is running, as there could be the rare but possible chance of two PRs triggering it close to each other, resulting in errors.

I'm not sure if cancel-in-progress: true is a good idea here, as it could cause one PR to not receive a deploy preview if it happens to be the one that gets the run cancelled. If I understand the concurrency option right will actions simply get delayed/queued up when one of the same group is running.

The main issue I see here is, that there isn't an easy way to delay actions for different PRs while cancelling actions for the same PR, so it's more or less a global thing here... If anyone has a good idea, let me know (I'll also ask in the GH Community discussion for help)

Andre601 commented 1 year ago

I decided to not use this... It just feels bad and GitHub's current way of handling concurrency is not something that would allow a more fine-tuned solution (i.e. queue up any runs if one is already active and cancel pending runs if the new one is from the same PR)