search

discord-jda / JDA-Website

Source for the JDA Wiki Website
https://jda.wiki
Apache License 2.0
11 stars 19 forks source link

Replace hardcoded logback version with placeholder #51

Closed EnzeGH closed 2 months ago

freya022 commented 6 months ago

I wouldn't do that as JDA uses SLF4J 1.X, later versions of logback uses SLF4J 2.X, which makes the logger not found

EnzeGH commented 5 months ago

I wouldn't do that as JDA uses SLF4J 1.X, later versions of logback uses SLF4J 2.X, which makes the logger not found

@freya022 Should we leave it as it is? JetBrains is warning about vulnerabilities. I just feel like giving a specific version feels wrong. What do you think?

freya022 commented 5 months ago

You could also override the slf4j version, add a placeholder for both slf4j and logback.

Also add badges so it shows the latest version for both on maven central