Closed Cespito closed 6 months ago
All these changes are superficial and not needed. Please don't open PRs that do not address concrete issues or offer meaningful improvements, especially avoid opening PRs that change many unrelated things at once.
Large unscoped changes like this are unwelcome. You could instead open specific PRs for individual issues, like replacing size() == 0
with isEmpty()
. It is much easier to accept or reject individual logical changes.
Please also avoid changing TweetNaclFast, that class should only be touched when absolutely necessary since it is actually a dependency that we copied rather than our own code.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
This pull request makes the following improvements:
Details
with
Benefits Improved code organization, maintainability, and readability. Reduced redundancy and enhanced robustness of the code.