Add more static analyzer annotations - Githubissues

discord-jda / JDA

Java wrapper for the popular chat & VOIP service: Discord https://discord.com

Apache License 2.0

4.26k stars 730 forks source link

Add more static analyzer annotations #2675

Closed MinnDevelopment closed 3 months ago

MinnDevelopment commented 3 months ago

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the contributing guidelines.

Changes

[x] Internal code
[ ] Library interface (affecting end-user code)
[x] Documentation
[ ] Other: _____

Closes Issue: NaN

Description

This causes static analyzers (Intellij etc.) to show warnings when using modification methods like add on one of these collections.

Additional, unrelated changes:

Removed deprecation of getUserByTag since it is still necessary
Added handling for parsing errors in retrievePinnedMessages
Added missing docs to Guild#retrieveActiveThreads