Refactor `LocalizationMapper` to enable more checks - Githubissues

discord-jda / JDA

Java wrapper for the popular chat & VOIP service: Discord https://discord.com

Apache License 2.0

4.26k stars 730 forks source link

Refactor `LocalizationMapper` to enable more checks #2676

Open freya022 opened 3 months ago

freya022 commented 3 months ago

Pull Request Etiquette

[X] I have checked the PRs for upcoming features/bug fixes.
[X] I have read the contributing guidelines.

Changes

[X] Internal code
[ ] Library interface (affecting end-user code)
[ ] Documentation
[X] Other: Tests

Closes Issue: NaN

Description

Refactors the localization mapper since we now have the full objects, instead of the raw data.

This enables the checks on options and choices, which wasn't possible before.

Since this now adds the localized strings on the Java objects (instead of JSON), you can read those after pushing the command to Discord.