search

discord-modmail / modmail

A Modmail bot for Discord. Allowing safe moderator conversations with server members one server at a time.
https://discord-modmail.readthedocs.io/
MIT License
15 stars 8 forks source link

Coverage: Migrate to coveralls? #112

Closed onerandomusername closed 2 years ago

onerandomusername commented 3 years ago

Description

Codecov is deprecating its uploader. Rather than continue to use codecov, we should shift to coveralls.

However, due to coveralls often having outages, this should be set in the workflow to always exit this step with 0, even if there was a failure.

Its probably possible to do some chaining with echo and stuff, see https://docs.github.com/en/actions/creating-actions/setting-exit-codes-for-actions#about-exit-codes

There also is the underlying question, do we need to have coverage reported at all?

Shivansh-007 commented 2 years ago

Would migrating to coveralls, lose all the coverage history we have in Codecov?

onerandomusername commented 2 years ago

Yes, but given how little coverage we've had up to this point, I don't think its worth blocking.

Shivansh-007 commented 2 years ago

Right, I would be approving this issue, not because of the outages as they can happen to anyone and coveralls has experienced them in past not fairly regularly but yeah quite a few times, and rather because of codecov deprecating its uploader.

onerandomusername commented 2 years ago

I've been trialing this, and have managed to get coveralls outages to not cause the workflows to fail, which is a good thing IMO