discord-modmail / modmail

A Modmail bot for Discord. Allowing safe moderator conversations with server members one server at a time.
https://discord-modmail.readthedocs.io/
MIT License
15 stars 8 forks source link

update export task to not infintely loop #27

Closed onerandomusername closed 3 years ago

onerandomusername commented 3 years ago

If task export was ran with poetry run, it was possible to error poetry in a way that never ended.

codecov-commenter commented 3 years ago

Codecov Report

Merging #27 (54681be) into main (6a4cebe) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #27   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          5       5           
  Lines        294     294           
=====================================
  Misses       294     294           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6a4cebe...54681be. Read the comment docs.

onerandomusername commented 3 years ago

It is really hard to go through the tasks, can we break them into sections with the help of comments and indent them multiline, this format:

[tool.taskipy.tasks]
export = { 
    cmd = "echo > requirements.txt && poetry export --without-hashes >> requirements.txt", 
    help = "Export installed packages in requirements.txt format" 
}

When I tried this I was getting errors, that it was not available pyproject.toml file.

Theres another format, if I recall correctly, which is [tool.taskipy.tasks.export] but that ends up being so verbose.

Shivansh-007 commented 3 years ago

Umm alright, then just break them into sections with comment headers.

onerandomusername commented 3 years ago

Above commit: image

If its below, then its at the bottom of this list.