Closed onerandomusername closed 3 years ago
Merging #58 (0d36e6e) into main (de403fd) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 35.49% 35.49%
=======================================
Files 12 12
Lines 555 555
Branches 64 64
=======================================
Hits 197 197
Misses 352 352
Partials 6 6
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update de403fd...0d36e6e. Read the comment docs.
@onerandomusername have you tested this on our providers?
Yes, this resets it to what it was in commit ff75614c8eca3988a37431fd492f6a1712ed2666
Ok
We could add a heroku.yml file in order to build a docker container on heroku as well. Perhaps we should do that, which would hopefully let us remove requirements.txt in a future pr, provided every integration works after this is merged.
I've managed to set up a heroku.yml file, which now means that heroku will deploy by creating a docker image,
however, I had to run heroku stack:set container
on the application, so I ended up making an app.json file.
This needs to be tested by deploying to heroku.
Testing if I can make this project deploy, and then we should be good to go.
Now that we have a dockerfile, one of our supported hosting platforms will use that file for running the bot, and will ignore the Procfile. This means that we can switch the process type back to worker, which is what our other supported hosting platform is expecting.