search

discord-modmail / modmail

A Modmail bot for Discord. Allowing safe moderator conversations with server members one server at a time.
https://discord-modmail.readthedocs.io/
MIT License
15 stars 8 forks source link

fix: install poetry with pipx when running in docker #74

Closed onerandomusername closed 2 years ago

onerandomusername commented 2 years ago

Installs poetry into a venv with pipx for docker.

This means that our dependencies and poetry's dependencies will not conflict.

codecov[bot] commented 2 years ago

Codecov Report

Merging #74 (2258c20) into main (b5ab21f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   38.62%   38.62%           
=======================================
  Files          16       16           
  Lines         769      769           
  Branches      105      105           
=======================================
  Hits          297      297           
  Misses        459      459           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5ab21f...2258c20. Read the comment docs.

Shivansh-007 commented 2 years ago

Could you also remove .gitattributes, we don't have that file anymore. A bit offtopic to this PR, but itsok

onerandomusername commented 2 years ago

UPDATE: I never tested this before now, but poetry is not needed to install and use importlib.metadata

It is fully possible to use pip install . and importlib.metadata will still work.

I'll be redoing this pull request to best execute this.