discord-modmail / modmail

A Modmail bot for Discord. Allowing safe moderator conversations with server members one server at a time.
https://discord-modmail.readthedocs.io/
MIT License
15 stars 8 forks source link

fix: paginator can now not use an embed #76

Closed onerandomusername closed 2 years ago

onerandomusername commented 2 years ago

The paginator now will not always use an embed. This allows non-embedded pagination since embeds are restricted to a maximum width which we cannot control, but codeblocks are restrained to the width of the screen.

codecov[bot] commented 2 years ago

Codecov Report

Merging #76 (c9b33a3) into main (4b07917) will decrease coverage by 1.55%. The diff coverage is 10.81%.

:exclamation: Current head c9b33a3 differs from pull request most recent head 81b5692. Consider uploading reports for the commit 81b5692 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   70.90%   69.34%   -1.56%     
==========================================
  Files          33       33              
  Lines        1619     1628       +9     
  Branches      199      207       +8     
==========================================
- Hits         1148     1129      -19     
- Misses        439      462      +23     
- Partials       32       37       +5     
Impacted Files Coverage Δ
tests/modmail/utils/test_pagination.py 100.00% <ø> (ø)
modmail/utils/pagination.py 33.96% <10.81%> (-9.01%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7347f59...81b5692. Read the comment docs.

onerandomusername commented 2 years ago

Will rebase.