discord-modmail / modmail

A Modmail bot for Discord. Allowing safe moderator conversations with server members one server at a time.
https://discord-modmail.readthedocs.io/
MIT License
15 stars 8 forks source link

fix: change dockerfile installation #81

Closed onerandomusername closed 3 years ago

onerandomusername commented 3 years ago

old way of docker installation would remove poetry's own dependencies causing poetry to fail installing a package if one of poetry's dependencies were a development dependency for the project image

the solution is to export all of the required packages to a requirements.txt file and then install them with pip even though this is a poetry bug, GH-69 needs to have an exported constraints.txt.

codecov[bot] commented 3 years ago

Codecov Report

Merging #81 (47fa69a) into main (b96f63a) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   33.25%   33.25%           
=======================================
  Files          17       17           
  Lines         893      893           
  Branches      132      132           
=======================================
  Hits          297      297           
  Misses        583      583           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b96f63a...47fa69a. Read the comment docs.

Shivansh-007 commented 3 years ago

Could you summarise on why we have shifted from poetry installation to pip, as I never faced any package errors in production or while developing.

onerandomusername commented 3 years ago

Could you summarise on why we have shifted from poetry installation to pip, as I never faced any package errors in production or while developing.

The basic summary is in the pr description, but this image below is what happens in the current dockerfile. I've also edited the pr description in order to better reflect this. image

While this is a poetry bug, GH-69 needs an exported constraints.txt file, so this is the best solution for this project.