search

discord-net / Discord.Net

An unofficial .Net wrapper for the Discord API (https://discord.com/)
https://discordnet.dev
MIT License
3.33k stars 736 forks source link

IAudioClient.Disconnect does not properly close the Voice Socket #103

Closed foxbot closed 8 years ago

foxbot commented 8 years ago

Steps to Reproduce:

  1. Connect to an audio channel
  2. Call IAudioClient.Disconnect();

What Should Happen: The bot will disconnect from the audio channel. What Actually Happens: The bot does not disconnect from the audio channel.

Versions Affected: 0.9.x, tested under 0.9.3 and 0.9.4

Flamanis commented 8 years ago

I believe this issue has something to do with Discord changing it's call for disconnecting from a voice channel. Code that worked previously does not work currently.

khionu commented 8 years ago

I'm looking into it

khionu commented 8 years ago

@420foxbot =.= Did you even start to look into this? Code hasn't changed since my PR to remove the hack. PEBCAK

https://github.com/RogueException/Discord.Net/commit/58025d303f0bb91e6122465e770db7902ce65ed9

khionu commented 8 years ago

Ok.... apparently this is a Discord issue.... looking into further

khionu commented 8 years ago

Issue confirmed on Discord.Py and Discord4J. This is a Discord Bug

meew0 commented 8 years ago

^ confirmed on discordrb

meew0 commented 8 years ago

Also confirmed on the airhorn bot (i.e. discordgo), which just gets stuck in a voice channel after playing the sound.

Flamanis commented 8 years ago

https://github.com/hammerandchisel/discord-api-docs/issues/90

Official response about it from H&C

khionu commented 8 years ago

Yes, we saw in Discord API, and we were the ones who brought it to them, so :P

foxbot commented 8 years ago

Closing; this is a Discord bug and it should be resolved soon.

foxbot commented 8 years ago

Should be resolved.