search

discord-php / DiscordPHP-Http

Asynchronous HTTP client used for communication with the Discord REST API.
MIT License
21 stars 9 forks source link

Crude implementation to allow Promise V3 #27

Open Exanlv opened 3 months ago

Exanlv commented 3 months ago

This is more of a proof of concept than a full PR.

26 introduces Promise V3 compatibility with the use of a helper. With an implementation like this, no helper is needed.

DiscordPHP will still be able to use Promise V2 by adding a hard Promise V2 dependency to composer.json, and if we include an IDE helper to overwrite the return types in DiscordPHP, nothing will have changed for users of DiscordPHP.

I'd like to hear what you guys think of a solution like this. I want to start using Promise V3, whether that be with #26, this PR, or a v3-compatible fork published on packagist alongside main discordphp-http.

SQKo commented 1 month ago

This is interesting approach, but i think since this depends on Composer, would be good to give user choice as a different version/different package for use in production, Do you know any example of non dev-tools library that is using any of the Composer utilities package?