Open valzargaming opened 1 year ago
All this should be in https://github.com/discord-php/DiscordPHP/tree/promise-v3 now
ExtendedPromiseInterface extends PromiseInterface, and Promise v2 implements ExtendedPromiseInterface, so instead of replacing the existing typehinting to PromiseInterface we could just use React\Promise\Promise, which would overcome the hurdle and be better for futureproofing code. This seems to be the ReactPHP developers' intent as well, given they have made all classes final to encourage composition.
It's painful to read this @valzargaming :) Code-ify more please.
It's painful to read this @valzargaming :) Code-ify more please.
This is already coded in the promises v3 branch as of today.
Per https://github.com/reactphp/promise/releases/tag/v3.0.0
Irrelevant:
Breaking changes:
Non-breaking changes: