Add 'approximate_guild_count' to application data

discord-php / DiscordPHP

An API to interact with the popular messaging app Discord

MIT License

977 stars 236 forks source link

Add 'approximate_guild_count' to application data #1155

Closed jocafamaka closed 1 year ago

jocafamaka commented 1 year ago

Depends on:

https://github.com/discord-php/DiscordPHP-Http/pull/22

key2peace commented 1 year ago

I think you missed something, see: https://github.com/discord/discord-api-docs/pull/5971/files#diff-ecb1aae3de6cf6faecb42d1e4ee6062fe79558a4b5d0876b1557b2d41c00d509R23

jocafamaka commented 1 year ago

In fact, I just skipped it, because I made this PR focused on 'approximate_guild_count' as stated in the title, because guild as it says in the documentation can be a partial object and I don't feel confident enough to do that treatment.

But I feel free to include it in the PR.

SQKo commented 1 year ago

The partial guild or even the guild_id is not relevant to bot gateways right now, afaik it's relevant to the application (which containing the bot), so it can be added later