Closed SQKo closed 12 months ago
Reported by Discord User dseguy that noticed there is duplicated switch value.
At first i thought the first one is supposed to be Op::VOICE_HEARTBEAT and checked the history it was replaced https://github.com/discord-php/DiscordPHP/commit/f18fe92033ddbfac4df178c6afe2aaeb340b3404#diff-7a2f3798bc3eb078cbf2d218a055dafd03180366955c157e610bc585940e634a I double checked the doc to see what Op::VOICE_HEARTBEAT does https://discord.com/developers/docs/topics/voice-connections#heartbeating, it is something that the voice client needs to send, not something that will be received, so the code is already correct, and so I'm just moving the event emitter so it gets triggered.
Op::VOICE_HEARTBEAT
Tested.
Reported by Discord User dseguy that noticed there is duplicated switch value.
At first i thought the first one is supposed to be
Op::VOICE_HEARTBEATand checked the history it was replaced https://github.com/discord-php/DiscordPHP/commit/f18fe92033ddbfac4df178c6afe2aaeb340b3404#diff-7a2f3798bc3eb078cbf2d218a055dafd03180366955c157e610bc585940e634a I double checked the doc to see whatOp::VOICE_HEARTBEATdoes https://discord.com/developers/docs/topics/voice-connections#heartbeating, it is something that the voice client needs to send, not something that will be received, so the code is already correct, and so I'm just moving the event emitter so it gets triggered.Tested.