search

discord-php / DiscordPHP

An API to interact with the popular messaging app Discord
MIT License
992 stars 236 forks source link

Allow Symfony 7 #1213

Closed Korbeil closed 5 months ago

Korbeil commented 6 months ago

Hello :wave: I'm trying to use v10 on a Symfony 7 application and it can't work because DiscordPHP does not allow Symfony 7.

I checked: https://github.com/symfony/options-resolver/blob/7.0/CHANGELOG.md there were no modifications since 6.4 so we can safely update this component and make DiscordPHP compatible with Symfony 7.

Also, for nestbot/carbon, as seen https://carbon.nesbot.com/docs/#api-carbon-3, I don't see anything that would make it a blocker.

It's my first time contributing here, please feel free to tell me if I've done anything wrong :pray:

SQKo commented 5 months ago

Thank you, while symfony's option resolver has no obvious changes, we decide to keep the Carbon at version 2 right now

Korbeil commented 5 months ago

@SQKo I splitted my PR in 2 smallers PR so you can merge them in any order you prefer.

Closing that one.