discord-relay-chat / drc

Discord Relay Chat
https://discordrc.com
MIT License
18 stars 3 forks source link

Disable embedding/crawling on URLs #28

Closed burritosoftware closed 6 months ago

burritosoftware commented 1 year ago

This would be a configurable option that encases all URLs being received in Discord with <> characters to prevent embedding/crawling of the URL by Discord's bot, for privacy.

edfletcher commented 1 year ago

This is a great idea! Will definitely add this đź‘Ť Thank you!

CovertDuck commented 1 year ago

Correct me if I’m wrong, but I believe that the generated URL previews are done via a Discord server and then served to the Discord client. So, receiving a link/embed message doesn’t compromise the user.

But that could change. Adding the brackets offers an additional layer of security, I'm all for it.

edfletcher commented 6 months ago

Resolved by https://github.com/discord-relay-chat/drc/commit/aeda423ba00bfb7da82774523c51c35d1a198881

The new setting is config.discord.disableUrlEmbeds and it defaults to true.

Enjoy, and thank you again for the idea @burritosoftware and the feedback @CovertDuck!