discord / discord-rpc

https://discordapp.com/developers
MIT License
1.05k stars 322 forks source link

Whitelist not working? #239

Closed andres-asm closed 5 years ago

andres-asm commented 5 years ago

Hi, I developed the ask to join implementation for RetroArch here. https://github.com/libretro/RetroArch/pull/7210 It was working fine, we were testing it with a whitelist and everything was going well till last week, but now we can't click the ask-to-join button even if whitelisted.

It shows and everything but it just won't let the other whiltelisted user click.

Anything going on? No changes on our end.

night commented 5 years ago

What client are you using, Stable or Canary (and on what operating system)? Do you know the date/time when it broke? Is there a photo/video of the behavior being exhibited?

Lachee commented 5 years ago

possible duplication of issue #238 ?

andres-asm commented 5 years ago

Sadly, no idea on the date My windows client is stable, build 26016 My linux client is stable, build 26016

The users are properly whitelisted.

image

msciotti commented 5 years ago

Not a duplicate of #238, but I think related. @paulshen since we changed this stuff to look at Dispatch as well, looks like we caught a snag across the board.

EDIT: See https://github.com/discordapp/discord-rpc/issues/238#issuecomment-429732150

msciotti commented 5 years ago

@fr500 can you try this again now? I believe the fix was deployed.

andres-asm commented 5 years ago

Sure, do I need to update the client? Because it's not showing updates for me

andres-asm commented 5 years ago

Seems to work in canary

andres-asm commented 5 years ago

Ok some more info, ask to join (canary to canary) seems to work in a windows host and linux asks to join scenario.

The other way around (linux hosts, windows asks to join) now gets this: image

This is seen on the joiner console

msciotti commented 5 years ago

If you expand that error, what's it say in the body?

andres-asm commented 5 years ago

image

The other way around is working 100% in canary tho

andres-asm commented 5 years ago

join from linux, windows host (works):

image

join from windows, linux host (doesn't):

image

andres-asm commented 5 years ago

This is a problem only when I host on linux so I'm assuming it's a problem on how the partyId and secret are encoded, gonna look for a fix now.

andres-asm commented 5 years ago

Yes, for some reason had to dup the partyId string on linux 🤷‍♂️

https://github.com/fr500/RetroArch/commit/17384f719f06f40e5ad1c9d009e72cf9e08c3813 Other than that, it's working