search

discord / erlpack

High Performance Erlang Term Format Packer
MIT License
217 stars 64 forks source link

feat: Compatibility for Node 16 #44

Closed icdevin closed 2 years ago

icdevin commented 2 years ago

Originally from https://github.com/Hazmi35

icdevin commented 2 years ago

@jhgg These are the original changes from the other 2 closed PRs.

promise commented 2 years ago

Reinstalling node-gyp should resolve compiling issues with node v16. Try npm uni -g node-gyp && npm i -g node-gyp. Me myself, and a friend of mine, have gotten it working doing this although we're not entirely sure if it will work for everyone.

It also looks like this is a dupe of #41, or the other way around. (#41 was reopened half an hour after this PR was made) Seeing as this PR originates from #41's author, I'd suggest closing this and instead having #41, but I'm not a maintainer so feel free to wait for a maintainer to give their input.

wrac4242 commented 2 years ago

Reinstalling node-gyp should resolve compiling issues with node v16. Try npm uni -g node-gyp && npm i -g node-gyp. Me myself, and a friend of mine, have gotten it working doing this although we're not entirely sure if it will work for everyone.

It also looks like this is a dupe of #41, or the other way around. (#41 was reopened half an hour after this PR was made) Seeing as this PR originates from #41's author, I'd suggest closing this and instead having #41, but I'm not a maintainer so feel free to wait for a maintainer to give their input.

Hi, the given command does not work for me, I still get the same compiling error trying to reinstall erlpack uname output Linux wrac-fedora 5.13.9-200.fc34.x86_64 #1 SMP x86_64 GNU/Linux

icdevin commented 2 years ago

@promise Agreed. Since he reopened it, I’ll shut this.

fredkilbourn commented 2 years ago

That command didn't fix things for me, either.

promise commented 2 years ago

Apologies, probably me having issues then.