discord / gamesdk-and-dispatch

Public issue tracker for the Discord Game SDK and Dispatch
22 stars 7 forks source link

[Feature Request] The rate limit for CreateLobby should be increase from 1 per 5 seconds to 5 per 5 seconds #31

Open hach-que opened 4 years ago

hach-que commented 4 years ago

As per the discussion in Discord, the rate limit for CreateLobby is currently set far too low, especially since there's a maximum of 5 concurrent lobbies per user anyway.

In my case, we have a party lobby for players (max 4 capacity), and then our matchmaking logic also create a separate lobby for the match (max 8 capacity for 4v4 matches). When you launch the game and get put into a party lobby by yourself, it's pretty easy to hit the rate limit if you queue up for matchmaking within 5 seconds of the party being made.

This is also an issue whenever someone leaves a party, since we create a new party lobby for them before disconnecting from the old one. This not only drastically simplifies our game code (since we can write code that always assumes the player has a party lobby present), but is fundamentally required to be able to take advantage of invites and join requests through Discord's rich presence, since you need the activity secrets from the party lobby in order for those features to function.

It's also likely the SDK isn't properly translating 429 Rate Limit errors from the Discord IPC back into RateLimited result codes, since the CreateLobby rate limiting error comes through as an InternalError result code.

PixelNinja132 commented 4 years ago

Yes! +1