search

discord / gamesdk-and-dispatch

Public issue tracker for the Discord Game SDK and Dispatch
22 stars 7 forks source link

Cannot build GameSDK under macOS and Linux #89

Open sylveon opened 4 years ago

sylveon commented 4 years ago

Describe the bug The GameSDK fails to build under macOS and Linux due to improperly written type definitions in ffi.h and discord_game_sdk.h

Steps to reproduce Steps to reproduce the behavior:

  1. Download the GameSDK on an Unix machine
  2. Try using it in a project

Expected behavior It builds

Implementation specifics

Additional context The issue is in lines 218-229 of discord_game_sdk.h and ffi.h. Those lines should be changed to the following (note the semicolons):

#ifndef _WIN32
  typedef void MSG;
  typedef void IDXGISwapChain;
#endif

Sidenote, but there's superfluous indentation on line 230.

msciotti commented 3 years ago

So we changed some underlying stuff in our latest version 3.1.0. Can I give you this and you can tell me if this issue still occurs?

https://dl-game-sdk.discordapp.net/3.1.0/discord_game_sdk.zip

sylveon commented 3 years ago

Looks resolved to me, albeit I don't have a Linux or macOS platform to test with at the moment.