search

discord / lilliput

Resize images and animated GIFs in Go
https://discord.com/blog/how-discord-resizes-150-million-images-every-day-with-go-and-c
Other
1.95k stars 123 forks source link

Fix handling of audio metadata, add unit tests showing supported formats. #148

Closed skidder closed 6 months ago

skidder commented 6 months ago

Parsing of audio metadata was broken with https://github.com/discord/lilliput/pull/145

This PR fixes that regression, and adds unit tests for supported audio formats. The change ensures that avformat_find_stream_info can run in the case of an audio file input.

The tests also demonstrate that AAC files are recognized, but parsed incorrectly, which is a longstanding bug. This will be addressed through a separate PR.

skidder commented 6 months ago

Got a verbal lgtm from @rcombs , merging