search

discordextremelist / website

The official source code for the website side of DEL!
https://discordextremelist.xyz
GNU Affero General Public License v3.0
75 stars 29 forks source link

build: add the `.js` extension on `start` script #258

Closed spifory closed 2 years ago

spifory commented 2 years ago

This pull request adds the missing .js extension in the start script, because Node assumes that app is a directory when it is a file, hence the app.js was added. Which finally becomes node --max-old-space-size=8192 dist/src/app.js.

IceeMC commented 2 years ago

Will not merge, not needed.

spifory commented 2 years ago

Will not merge, not needed.

But when executing the command, it assumes that dist/src/app is a directory, instead of a file, which will cause a MODULE_NOT_FOUND error.

IceeMC commented 2 years ago

Ok, but it works for us.

spifory commented 2 years ago

Ok, but it works for us.

Well, that is fair, but this was mostly made because DEL(ly) is allowed to be self-hosted by people, which is why I made this minimal fix — Which, I do understand that the self-hoster can easily fix this. And technically the extension(.js) is added to the following comamnds: https://github.com/discordextremelist/website/blob/main/package.json#L82 https://github.com/discordextremelist/website/blob/main/package.json#L77 https://github.com/discordextremelist/website/blob/main/package.json#L6

IceeMC commented 2 years ago

Yes but we do not support self hosting and probably never will.

spifory commented 2 years ago

Yes but we do not support self hosting and probably never will.

Ah. Well I guess the person hosting will just have to change it themselves, which I understand, as I mentioned that it's a very minimal thing to change. Thanks for the confirmation 😊

advaith1 commented 2 years ago

Since we haven't had any issues with this, you should probably look into why your setup is having an issue.

spifory commented 2 years ago

Since we haven't had any issues with this, you should probably look into why your setup is having an issue.

It's likely Windows, but I'm not very certain as I haven't seen whether it happens with other operating systems either. It's most likely my Node version, apparently I was on the LTS version instead of the latest 😅