Closed carolinaisslaying closed 5 months ago
carolinaisslaying
commented
6 months ago idk what deepscan is up to since I can't find I way to remove it anywhere since it's not letting me access it since I am not a member of the project apparently lol, and nothing shows how to remove it on GitHub which is bizarre but whatever
carolinaisslaying
commented
6 months ago I've managed to completely break CSS somehow, and I have no clue how or why, just wondering if anyone is able to have a look for me or has an idea what I've done wrong? It was okay not too long ago? I'll look properly tomorrow sometime but pain.
Cannot repro in main branch, will aim to try check a few commits and see where the issue was introduced and go from there if I need to.
carolinaisslaying
commented
6 months ago fix for css wasn't pretty but it works, working on the css splitting up and sorting out stuff can wait for a future release
The goal of this pull request is to provide a medium-term solution in combination with @TheAlienKnight's fixes. Aiming to fix a number of bugs reported in the issues tab on this repo and fix things I come across.
His fixes very much fixed a lot of key integral things, but it's important to also build off of that and update more things where possible.
An example as of writing is switching to express-session and using Redis as a store instead of cookie-session and storing session information in cookies which, certainly isn't ideal and when updating passport to resolve its security vulnerabilities, rendered cookie-session unable to work with it due to newer breaking changes in passport.
The idea of this is not to be a silver bullet and fix everything that needs fixing, but fix a lot of the more high priority issues in functionality (or well, at least an attempt, lol), as well as address some of the more easier to fix bugs that have been reported, and high priority ones.