search

discordia-space / CEV-Eris

Death is our destination
https://discord.gg/QfEg7K7
Other
152 stars 496 forks source link

New Material Exchange Vendor #8459

Closed vode-code closed 6 months ago

vode-code commented 8 months ago

About The Pull Request

This PR adds the AME Vendor System and Silo, which provides materials in exchange for 6 fifths of their price, and buys them for 4 fifths of their price, providing a stable valuation for materials. To accompany this, many items without material values have had matter set, with one exception, which was removed from spawning entirely. also reduced cost of makeshift electrolyser from 4 steel and 30 coil units to 4 steel and 10 coil units.

Why It's Good For The Game

Material Sales should always be possible, regardless of pop, and this works as a middle agent that cannot enter a war with you and die. the material additions make maint loot more processable, instead of just being nearly worthless in any form.

Testing

used all features of recycler and silo successfully

Changelog

:cl: add: Added Automated Material Exchange system add: many maint-loot items with no material contents have had materials added. tweak: Makeshift Electrolyser recipe now requires less wire. /:cl:

TheShown911 commented 8 months ago

Does no pass no linter man get this outta here

ValoTheValo commented 8 months ago

with one exception, which was removed from spawning entirely.

what is the exception

vode-code commented 8 months ago

with one exception, which was removed from spawning entirely.

what is the exception

Z8 grenade launcher... except without Z8, so it's just weird.

hyperioo commented 8 months ago

@vode-code Issue comes from the template you added. There is no detail about the error, you could try to manually run Prettier on it to see if it fixes something ?

=> Finished 'tgui-tsc' in 14.651s
[warn] packages/tgui/interfaces/FrontNode.tsx
[warn] Code style issues found in the above file(s). Forgot to run Prettier?
vode-code commented 7 months ago

turns out messing with forces you don't comprehend has consequences, for while the linters now work, everything but the icons and the linters are broken.

vode-code commented 7 months ago

I have successfully made everything fail.

Mycah142 commented 7 months ago

image

vode-code commented 7 months ago

I am at the perfect level of skill where I know what I am doing wrong, but not the solution- I just need to fix everything I broke!

vode-code commented 7 months ago

turns out I was wrong- it wasn't something I broke recently, but a merge based error I didn't remember to fix.

Mycah142 commented 7 months ago

Discord_oQmMINjZE0 What is there to discuss?

SirRichardFrancis commented 7 months ago

What is there to discuss?

Implementation of this PR.

Humonitarian commented 7 months ago

Discord_oQmMINjZE0 What is there to discuss?

Distance teleportation of materials, which would have caused people not to congest at Guild. We handled it via Discord.