Links Security Status to Sechuds

[thedarkcrusader]

About The Pull Request

This PR links the security record. field from crew records to sechuds allowing them to be seen by those wearing sechuds

Why It's Good For The Game

Allows for much Better in field keeping up to date with incidents. and problems without having to run to a computer every

single time just to see a person's history.

Testing

spawned in as operative. edited secrecords from console viewed myself with sechuds Records appeared as normal

Changelog

:cl: tweak: sechuds now draw their information from the crew record program. /:cl:

[thevandie]

Failed integration test, L bozo

[thedarkcrusader]

Contributor

Intergration failed?? why don't you go inter into some bitches homes.

[thevandie]

Intergration failed?? why don't you go inter into some bitches homes.

I am not a crook.

[thedarkcrusader]

Records appeared as normal

How does it work with old chat (believe it or not, it needs to work with old chat), how it works if record contain Details (stuff you add in character setup)?

Anything added to security status in setup will appear let me check it in old chat rq tho should still be fine

[thedarkcrusader]

Records appeared as normal

How does it work with old chat (believe it or not, it needs to work with old chat), how it works if record contain Details (stuff you add in character setup)?

still works with Old chat but the some of the HTML code like boxes don't show up properly. otherwise works as normal

[Firefox13]

Screenshots please?

[thedarkcrusader]

Screenshots please?

[thedarkcrusader]

This is no bueno, spacings are so massive that half the chat is blank. Even if some information is meant to be there, text should be compressed for cases when there isn't any.

Those spaces are from my HTML layout

[SirRichardFrancis]

Those spaces are from my HTML layout

So? Make them disappear.

[thedarkcrusader]

Those spaces are from my HTML layout

So? Make them disappear.

Allright it's gone poof

[thedarkcrusader]

Poo

This is no bueno, spacings are so massive that half the chat is blank. Even if some information is meant to be there, text should be compressed for cases when there isn't any.

On a more serious note would you by. Chance know how one could do that compression??

[SirRichardFrancis]

On a more serious note would you by. Chance know how one could do that compression??

As a matter of fact, I can't find the code responsible for this, since text from your screenshots does not appear to be in the build, and neither is added by this PR. You're sure that no changes remain uncommitted?

[thedarkcrusader]

On a more serious note would you by. Chance know how one could do that compression??

As a matter of fact, I can't find the code responsible for this, since text from your screenshots does not appear to be in the build, and neither is added by this PR. You're sure that no changes remain uncommitted?

Im positive which text are you referring to ?

[SirRichardFrancis]

Im positive which text are you referring to ?

Anything from the screenshot you put in PR description.

For example let's take last table header.

Or some of the blue text.

Other word perhaps?

There could be all sorts of weird formatting in strings, which could make them borderline unsearchable, but individual words always fair game. Yet there isn't any in the code. This table and text around it doesn't seem to exist anywhere. So I have absolutely no clue where this table is coming from, as such can't help with formatting it properly.

[SirRichardFrancis]

If you made that table in your character's records, then this is nonsensical feature presentation.

[thedarkcrusader]

If you made that table in your character's records, then this is nonsensical feature presentation.

I mean how would you expect me to show it off this is quite literally one of the end results of editing the security records.

[thedarkcrusader]

,

If you made that table in your character's records, then this is nonsensical feature presentation.

[SirRichardFrancis]

I mean how would you expect me to show it off this is quite literally one of the things people are able to do now

Using something realistic, like what an actual player, that seen the sun at least once in past three years, could write? PR description made me think that every sechud examine will have that cursed HTML table. Since that's apparently just a skill issue on the player part, I have no objections.

[MLGTASTICa]

Note for maintainers , someone should really check if sec records are actually sanitized in the field that this PR outputs , else someone could inject JS.

[thedarkcrusader]

why is this conflicting?

[SirRichardFrancis]

why is this conflicting?

Because you and someone else (who got their PR merged first) have edited the same file. Just pull upstream/master on your local branch, solve the conflict in VSC, save file, git add, git commit, and git push. 5 minutes adventure.

[thedarkcrusader]

why is this conflicting?

Because you and someone else (who got their PR merged first) have edited the same file. Just pull upstream/master on your local branch, solve the conflict in VSC, save file, git add, git commit, and git push. 5 minutes adventure.

Ahh jeez rick i don't want to go on a 5 minute adventure

[Humonitarian]

Merge conflicts still present.

[thedarkcrusader]

Merge conflicts still present.

im prob gonna kill this i think there is a better way to do this

[thedarkcrusader]

Bye bye conflicts