discordia-space / CEV-Eris

Death is our destination
https://discord.gg/QfEg7K7
Other
152 stars 496 forks source link

Mech drill rework #8481

Closed XElectricX closed 6 months ago

XElectricX commented 6 months ago

About The Pull Request

Summary of changes:

Why It's Good For The Game

Funny drill go brrr and better code.

Testing

Drill works as normal. Can mine, dig up sand, drill my through the entire ship, and the timers work accordingly.

Changelog

:cl: balance: Mech drill speed scales off material hardness; minor speed adjustments. fix: Mech drills were not able to mine by bumping into walls. code: Mech drill code is more organized. refactor: General mech drill improvements. /:cl:

Holvr0 commented 6 months ago

I'm naturally in favour of - as you put it - better code, but why the change from 3 tiles to 1? The whole point of mech drill was that it can grind down whole swaths of terrain at once, as opposed to just 1 tile at a time like a handheld drill. Even if 1 is being dug out faster than 3, it's still not a good change.

At most, it could be a toggleable drilling mode - drill really fast and narrow, or slower and broad - but not a permanent removal of the latter.