discordia-space / CEV-Eris

Death is our destination
https://discord.gg/QfEg7K7
Other
152 stars 496 forks source link

[COMMISSION] New mech weapons: club, bow & BFG #8486

Closed cheesePizza2 closed 3 months ago

cheesePizza2 commented 6 months ago

About The Pull Request

Remake of #8456, with permission from the author.

Adds 3 new mech weapons:

Why It's Good For The Game

More weapon variety, as well as some integration with the materials system.

Testing

Mace can be used to attack others. Mace can be swapped to and from flail mode. BFG charging is properly handled. Crossbow charging is properly handled. Crossbows can be refilled and used properly. Filling a half-filled crossbow takes fewer sheets (as intended) and using fewer sheets than possible grants fewer shots (as intended).

POSSIBLE IMPROVEMENTS: Mace flail sprite is a duplicate of the mace sprite. BFG and crossbow charging can sometimes trigger a drag-click. BFG and crossbow charging don't play a sound or make a light.

Changelog

:cl: Cheesepizza2, Doster-D add: Added a new mech weapon: the NT \"Warhead\" mace! In its mace mode, it will absolutely obliterate structures and people. Using it in hand will convert it to a flail that does less damage but has a longer range and weakens + knocks back targets. add: Added a new mech weapon: the BFG! After a lengthy charging period, this massive cannon shoots a massive bolt of plasma energy that does loads of damage in a wide radius. add: Added a new mech weapon: the mounted crossbow! Insert in materials to load as crossbow bolts - the harder and heavier the material, the more armor penetration and damage it has respectively. /:cl:

SirRichardFrancis commented 6 months ago

Screenshots?

cheesePizza2 commented 3 months ago

Alright, all three modules are functional, although in need of polishing (and a missing sprite).

cheesePizza2 commented 3 months ago

Tested, everything is in order except:

Working with my commissioner to correct the first. Latter two aren't breaking issues and would take some further code fuckery to fix.

cheesePizza2 commented 3 months ago

I don't think he has a sprite for flail in-hand so I'm just gonna duplicate the regular one. This is good enough for review.

P.S. I kinda want this in sooner rather than later, so uh, maintainers have full permission to make changes without asking if it'll get this through faster.

Humonitarian commented 3 months ago

If there is any balance issues, we can patch it once we find it.