discordia-space / CEV-Eris

Death is our destination
https://discord.gg/QfEg7K7
Other
151 stars 500 forks source link

AME Overhaul #8487

Closed vode-code closed 4 months ago

vode-code commented 4 months ago

About The Pull Request

THIS PR fixes several bugs, improves quality of life in using the administration panel of the Silo, and ensures that the AME does not run entirely dry of credits via a subsidy system.

Why It's Good For The Game

The credit must have value for the economy to function. Without the AME, the value of the credit is backed by trade stations, which are often unavailable, and vendors, which have very specific types of items available and very limited stocks of these items.

With the AME, but with the ability for too much of a single type of material to be sold to it depleting its credits, it becomes plausible that the AME becomes incapable of buying materials people want. That makes it so that money is also backed by the single material which it has in stock, and if no one wants that material, credits value remains insignificant. The Subsidy ensures the AME can continue to buy materials even if it isn't making enough money to pay for the materials that do not have sufficient demand, in exchange for being forced to pay the Subsidy back once the AME starts to make enough profit to no longer need external funding to operate. This ensures that the credit is backed by the material that is highest demand and supply, ensuring the credit has value.

Testing

Taxes built up properly ghost credit, matterless item, ammo box/knife spritesheet, and duplicate-item recycling bugs successfully fixed and tested Silo administration panel opened and appeared correct

Changelog

:cl: Chickenish balance: The AME is now subsidized by Command where necessary in exchange for paying taxes. fix: fixed a few things wrong with Silo. /:cl:

vode-code commented 4 months ago

snack error and rigged cell error.

SirRichardFrancis commented 4 months ago

About The Pull Request

Singleplayer Eris let's go. Cap will pay for everything.

Why It's Good For The Game

Everything is worth what its purchaser will pay for it.

vode-code commented 4 months ago

Why It's Good For The Game

Everything is worth what its purchaser will pay for it.

this is the EXACT correct line of thinking.

vode-code commented 4 months ago

About The Pull Request

Singleplayer Eris let's go. Cap will pay for everything.

Captain gets his money back, guaranteed. him having to pay for too much would be a maints issue, not an AME issue.

SirRichardFrancis commented 4 months ago

this is the EXACT correct line of thinking.

My line of thinking was "that statement doesn't explain a thing, and is completely unrelated, I'll go pull up a random ass quote to make fun of this :mitosis:"

vode-code commented 4 months ago

this is the EXACT correct line of thinking.

My line of thinking was "that statement doesn't explain a thing, and is completely unrelated, I'll go pull up a random ass quote to make fun of this :mitosis:"

will fix.

SirRichardFrancis commented 4 months ago

Captain gets his money back, guaranteed.

Explain to me how is this going to work. Or how you wanted this to work, with math.

him having to pay for too much would be a maints issue, not an AME issue.

What?

vode-code commented 4 months ago

him having to pay for too much would be a maints issue, not an AME issue.

What?

answering the second question first- a significant weakness of this system is if there is so much more vendor trash in maints than demand for it, it is possible for 7920 sheets of each low-demand high-supply material to build up before it auto-sells and starts paying the captain back.

vode-code commented 4 months ago

T > 100 && Budget >= MINIMUM_BUDGET = Taxes.

Humonitarian commented 4 months ago

Code review still in progress, also integration tests failed, might want to look into that.

vode-code commented 4 months ago

Code review still in progress, also integration tests failed, might want to look into that.

see first comment.

TheShown911 commented 4 months ago

What could go wrong?