search

discordia-space / CEV-Eris

Death is our destination
https://discord.gg/QfEg7K7
Other
152 stars 496 forks source link

Fixes missing insight when fulfilling a goal while already inspired #8494

Open dingleberrypicker opened 5 months ago

dingleberrypicker commented 5 months ago

About The Pull Request

You lose ALL insight when you finish focusing, no matter if it goes over 100. This fixes the edge cases when you fulfill a goal right before finishing your current insight, and thus lose an additional 100 insight.

Why It's Good For The Game

Testing

Changelog

:cl: Buttcrack Berry Picker fix: fixed losing all insight when you focus, instead of just your max cap /:cl:

dingleberrypicker commented 5 months ago

@TheShown911 @ACCount12 Hi~

Humonitarian commented 5 months ago

There was a bug that allowed insight to rise over 100 on artist, might want to check if its still present, as that would allow some potential exploits.

dingleberrypicker commented 5 months ago

artist_bench now capped at 100 insight maximum investment even if you evade the prompt, should be fine

dingleberrypicker commented 4 months ago

why dis shit failing doe?

SirRichardFrancis commented 4 months ago

why dis shit failing doe?

[19:18:37] Runtime in utility.dm,914: Cannot execute null.forceMove().

Proc ejectLifting() got called without a prerequisite check (which should probably be a part of the proc itself, but that's another story). Known bug that is thought to be fixed on up-to-date Master branch. Either it wasn't actually fixed, or you've used slightly outdated branch for this PR.

MLGTASTICa commented 4 months ago

why dis shit failing doe?

[19:18:37] Runtime in utility.dm,914: Cannot execute null.forceMove().

Proc ejectLifting() got called without a prerequisite check (which should probably be a part of the proc itself, but that's another story). Known bug that is thought to be fixed on up-to-date Master branch. Either it wasn't actually fixed, or you've used slightly outdated branch for this PR.

its actually a bit more unusual than that.. apparently it tries to out-lift a turf (which can't move), so its either null because 1)the turf is marked for deletion and so are all its contents , or 2)theres a massive fuck up somewhere thats allowing turfs to be picked up.

Edit: took a look at it , i misread the situation at first(oops), objects were getting marked for delayed deletion by the garbage systems and were stalled out because they were still being referenced(stuff shouldn't delete in the clamps)