discordia-space / CEV-Eris

Death is our destination
https://discord.gg/QfEg7K7
Other
152 stars 496 forks source link

Update nanites.dm #8520

Closed AltHit closed 2 months ago

AltHit commented 3 months ago

About The Pull Request

Band-aid fixtng FBP nanites, now they are at least working

Why It's Good For The Game

Not working chem = not gud for game => Fixed chem = Good for the game

Testing

Broke my own ribcage with with a cleaver to test if repair works Then started up test server, drunk 10u. of nanites [VV shows 0.75 CE_MECH_REPAIR]. Made few organ wounds to myself in a natural way, organ wounds don't heal because CE_MECH_REPAIR is lower than 0.85. Added aluminum, iron and copper to nanites [VV shows 0,9 CE_MECH_REPAIR]. Wounds healed.

Changelog

:cl: fix: repair nanites for FBP now work correctly and heal /:cl:

AltHit commented 2 months ago

I wanted to object that we have 9 easily obtainable metals and so it would be easy get the necessary numbers in-game, but... Testing reminded me that our chemistry system is fundamentally idiotic and doesn't work the way anyone may expect. Anyways, this "metals boost/required for nanite healing" business sounds cool on paper, but as far as I see it have proved to be unnecessary and plain bad, dysfunctional game mechanic. Then again, if you say it's okay with the fix, then it probably is.

Well... This fix is in no way a final sollution. This little patch here just makes it so this mechanic is at least working (as opposed to being completely broken and non-functional). We are working on rewriting this organ healing system right now and when better solution will be made - we will move there. Until then - drink you unranium and wait

Also thank you so much! I made like 3 PRs and this is first real review I got in weeks