discordia-space / CEV-Eris

Death is our destination
https://discord.gg/QfEg7K7
Other
152 stars 496 forks source link

Fix window interactions #8523

Closed SirRichardFrancis closed 2 months ago

SirRichardFrancis commented 2 months ago

About The Pull Request

I've been told a couple of days ago that full-tile windows can't be knocked at, can't tell lasers and bullets apart, and that low walls are not grab-fu certified. Also I've apparently forgot to write low wall description, oopsie.

Additionally, wall icon updates are somewhat more customizable now, with appearance cache supporting use of multiple .dmi files for walls (where icon names match these from other used .dmi), as well as custom alpha value for windows based off the wall type.

Why It's Good For The Game

Fixes cool. Customization changes made on request from a downstream.

Testing

Knocked on a window with harm and help intents. Touched a low wall with no window. Touched a regular wall.

Shot a window with a laser gun, observed laser pass right through. Shot a window with ballistic gun, observed bullet impact the window. Shot a low wall with no window with ballistic gun, observed bullet pass right through.

Used blue grab on a low wall with no window, observed grabbed mob being put on a low wall. Used blue grab on a window, observed mob not moving anywhere. Used blue grab on a regular wall, observed mob not moving anywhere.

Changelog

:cl: fix: Fixed several interactions with windows. /:cl:

TheLeopold commented 2 months ago

What about this? изображение

SirRichardFrancis commented 2 months ago

What about this?

What about it? image

TheLeopold commented 2 months ago

What about it? image

It doesn't seem to be fixed. Smashing someone into a window interaction is still missing.