search

discordianfish / nginx_exporter

Simple server that scrapes nginx stats and exports them via HTTP for Prometheus consumption
MIT License
160 stars 76 forks source link

Use locked dependencies; other improvements #27

Closed jwkohnen closed 6 years ago

jwkohnen commented 7 years ago

Today I had to restart a service which failed to come up due to #23. Due to that occasion I took a closer look and implemented a few improvements that help to make build reproducible. The fix by EdSchouten #24 is included in this PR.

Please consider to release with semantically versioned git tags and maybe publish containers using automated builds.

See also #26.

discordianfish commented 6 years ago

Hi,

sorry for not seeing this earlier. This looks good, thanks! Can you rebase it and maybe update dep?

Agree with everything you said and happy to merge further changes to add build configs. So far I just didn't get to it.

jwkohnen commented 6 years ago

Sure, no problem. I've created a new PR #33 for that, though.

There should be no further changes needed in order to create an automated build on docker hub. Just create an automated build repository on hub.docker.com and point it to your GitHub repository.

discordianfish commented 6 years ago

Last time I tried it wasn't possible to sync git tags with image tags. Is that possible now? But I suppose I could just manually create a release for now.

jwkohnen commented 6 years ago

Uh yes, I remember. For "automatically" building tags, one has to create a build trigger for each tag. Which is not exactly automatic, but whatever. :)