Allow override of Command.throttle

discordjs / Commando

Official command framework for discord.js

Apache License 2.0

497 stars 243 forks source link

Allow override of Command.throttle #372

Closed CS-Birb closed 3 years ago

CS-Birb commented 3 years ago

Make Command.throttle protected instead of private, allowing children to safely override this handling when using typescript.
Fix the return type of Command.throttle to acknowledge the null response where a command is not throttling.

Given throttling is a per-command behaviour, it would be handy to be able to provide custom throttling checks as needed. I.e. throttling for all (incl. owners), global throttling instead of per-user, etc

CS-Birb commented 3 years ago

Commit ammended to update JSDoc from @private to @protected (Missed in initial commit)