fix(Command): respect bypassGroup for cmds ran in DMs - Githubissues

discordjs / Commando

Official command framework for discord.js

Apache License 2.0

497 stars 243 forks source link

fix(Command): respect bypassGroup for cmds ran in DMs #385

Closed guidojw closed 3 years ago

guidojw commented 3 years ago

Command#isEnabledIn doesn't take the bypassGroup argument into account if the method is called with guild=null (DMs). This PR fixes that.

I found this bug by doing:

in DMs with the client try to enable an already enabled command which is in a disabled group.
it says the "enabled command but group is disabled" message.

What should happen:

it should say the "command is already enabled but group is not" message, like when you use enable on a command with equal state in guilds.