discordjs / Commando

Official command framework for discord.js
Apache License 2.0
497 stars 243 forks source link

Problems with the CommandDispatcher interface? #390

Open GreenCappuccino opened 3 years ago

GreenCappuccino commented 3 years ago

The handleMessage method in CommandDispatcher is private. This doesn't seem to make sense?

handleMessage is called in the constructor of the Commando client, and nothing in CommandDispatcher actually calls it.

So, it seems like this should be a public method? I'm writing a child class in TypeScript of CommandDispatcher to intercept all messages, and this interface definition is causing problems.

Is there a design decision behind this, or should this be changed?