search

discordjs / Commando

Official command framework for discord.js
Apache License 2.0
497 stars 243 forks source link

fix: replace resolveString with verifyString #402

Open monbrey opened 3 years ago

monbrey commented 3 years ago

Replaces a reference to the now removed Util.resolveString with Util.verifyString Introduced by https://github.com/discordjs/discord.js/pull/4880

ghost commented 3 years ago

I just tested this PR and looks like this.options is giving the error TypeError: Cannot read property 'content' of undefined, without the this.options is working fine

ghost commented 3 years ago

Shouldn't StringResolvable be Replaced with string in the Typings?

kyranet commented 3 years ago

StringResolvable is being used for message sending and editing, both of which are changing in https://github.com/discordjs/discord.js/pull/5758

Once the PR has landed, this can be updated and fix two breaking changes together.

monbrey commented 3 years ago

I don't believe this PR should address both changes, no. I will update the typing though.

kyranet commented 3 years ago

Oh, yeah mb, I thought this was a PR for updating Commando for v13.

ghost commented 3 years ago

Oh, yeah mb, I thought this was a PR for updating Commando for v13.

There are a lot of things missing to support v13, This is getting kinda off-topic lets discuss on library-discussion if You want.

arifali123 commented 3 years ago

can this be merged so we can use commando with the master version of discord.js

ghost commented 3 years ago

This PR just Broke lmao, now You get verifyString is not a function

kyranet commented 3 years ago

It's still in there: https://github.com/discordjs/discord.js/blob/master/src/util/Util.js#L403

Are you sure you didn't change back to 12.5.3?

ghost commented 3 years ago

It's still in there: https://github.com/discordjs/discord.js/blob/master/src/util/Util.js#L403

Are you sure you didn't change back to 12.5.3?

Yea I didn't changed back to 12, He Just forgot to add .Util after requiring d.js