search

discordjs / Commando

Official command framework for discord.js
Apache License 2.0
497 stars 243 forks source link

Rewrite Commando for discord.js master #412

Closed retraigo closed 2 years ago

retraigo commented 2 years ago

Uhh so just tried to rewrite discord.js commando.

Since structures were removed in the master branch, I tried directly modifying the prototypes so it's kinda hacky but it still works without any bugs so far (tested all commands in the test directory)

There are not many changes except for rewriting all Utility function imports from ('discord.js') to ('discord.js').Util and completely rewriting the structure extensions,

This has been tested with the master branch of discord.js and I am yet to encounter any bugs since the latest commit.

I'm not sure if creating a pull request to master would be a good idea but I just wanted to try.

The changes are breaking and do not work with discord.js v12.

retraigo commented 2 years ago

I was probably high when I made this. This PR is just the apex of "DUMB". I'ma close this.

KitsuneDev commented 2 years ago

With V13 now officially out, won't this PR be useful to updating the Commando framework?

retraigo commented 2 years ago

Nah that PR was hacky af. I made a better, non-hacky version a few days ago but its pointless rn. Commando no longer serves a purpose since Discord is now forcing slash commands on verified bots.