Closed AxelTerizaki closed 3 years ago
@devsnek this is a blocking issue for 4.x, have to revert..
I won't be reverting this.
Excuse me @devsnek but my main question was if you planned to offer pre-built binaries for this so it won't trigger any error message? It's not blocking but the node-gyp messages are confusing and can lead to useless questions from users.
As I understand the changelog, register-scheme has been moved from peer dependencies to optional.
Moving it to optional also made it trying to build register-scheme using node-gyp, however, on systems without any build tools, it fails. Since the package is optional, yarn/npm doesn't abort, but it still displays a confusing error message to the end-user trying to pull discord-rpc.
One easy solution would be to revert it to peer dependency, but another would be to provide pre-built binaries for node-register-scheme on different systems. Most packages which include bindings provide these so install doesn't fail.
For now I'll stick to the previous version to keep my users from panicking when they're installing my app :)