search

discordjs / RPC

A simple RPC client for Discord
MIT License
459 stars 190 forks source link

Fixed variable naming issue #174

Closed Adhiraj10 closed 1 year ago

Adhiraj10 commented 1 year ago

This pull request aims to fix #173.

I have made appropriate changes to the client.js file in the src folder such that variable naming won't cause the 'connection closed' error. Developers writing code for custom rich presence can use any variable name instead of 'clientId' and 'accessToken' only. For more info about the error, please check #173

Changes Made

MattIPv4 commented 1 year ago

This user cold DM'ed me on Discord asking to take a look at this -- this change makes absolutely zero sense and breaks how the login method works. Yes, it works if you pass a perfect object where the first two key/value pairs happen to be clientId and then accessToken, but in any other scenario it does not. It is an object, and it is being destructured, as it should be.