discordjs / builders

A collection of builders that you can use when creating your bot.
Apache License 2.0
97 stars 37 forks source link

fix: properly type `toJSON` methods #34

Closed suneettipirneni closed 3 years ago

suneettipirneni commented 3 years ago

Please describe the changes this PR makes and why it should be merged:

Adds return types for toJSON that correspond with discord-api-types

Status and versioning classification:

codecov-commenter commented 3 years ago

Codecov Report

Merging #34 (3695209) into main (2aecbe4) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        18    +3     
  Lines          144       233   +89     
  Branches        21        33   +12     
=========================================
+ Hits           144       233   +89     
Impacted Files Coverage Δ
.../interactions/slashCommands/SlashCommandBuilder.ts 100.00% <ø> (ø)
...eractions/slashCommands/SlashCommandSubcommands.ts 100.00% <ø> (ø)
src/interactions/slashCommands/Assertions.ts 100.00% <0.00%> (ø)
...nteractions/slashCommands/mixins/CommandOptions.ts 100.00% <0.00%> (ø)
...s/slashCommands/mixins/CommandOptionWithChoices.ts 100.00% <0.00%> (ø)
src/messages/embed/Embed.ts 100.00% <0.00%> (ø)
src/messages/embed/Assertions.ts 100.00% <0.00%> (ø)
src/interactions/slashCommands/options/number.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2aecbe4...3695209. Read the comment docs.