feat: `Builder#toData` - Githubissues

discordjs / builders

A collection of builders that you can use when creating your bot.

Apache License 2.0

97 stars 37 forks source link

feat: `Builder#toData` #39

Closed suneettipirneni closed 2 years ago

suneettipirneni commented 2 years ago

Please describe the changes this PR makes and why it should be merged:

Closes #38

Status and versioning classification: Please move lines that apply to you out of the comment:

Code changes have been tested against the Discord API, or there are no code changes
I know how to update typings and have done so, or typings don't need updating
This PR changes the library's interface (methods or parameters added)

vladfrangu commented 2 years ago

I'm not really a huge fan of the naming, nor the need for this in this module.. shouldn't this be a discord.js PR instead @discordjs/the-big-3?

kyranet commented 2 years ago

To be honest, we should just make d.js compatible with this.

Having a library depend on another that depends on it (circular dependency) can also be a pain to maintain.

suneettipirneni commented 2 years ago

To be honest, we should just make d.js compatible with this.

Having a library depend on another that depends on it (circular dependency) can also be a pain to maintain.

Understood, I'll go ahead and close this