suneettipirneni commented 2 years ago

Please describe the changes this PR makes and why it should be merged:

Co-requisite with https://github.com/discordjs/discord-api-types/pull/221

https://github.com/discord/discord-api-docs/pull/3967

Status and versioning classification: Please move lines that apply to you out of the comment:

Code changes have been tested against the Discord API, or there are no code changes
I know how to update typings and have done so, or typings don't need updating
This PR changes the library's interface (methods or parameters added)

codecov-commenter commented 2 years ago

Codecov Report

Merging #47 (e27d446) into main (24bfcd7) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        22    +1     
  Lines          264       279   +15     
  Branches        33        33           
=========================================
+ Hits           264       279   +15

Impacted Files	Coverage Δ
...ns/slashCommands/mixins/CommandNumberOptionBase.ts	`100.00% <100.00%> (ø)`
src/interactions/slashCommands/options/integer.ts	`100.00% <100.00%> (ø)`
src/interactions/slashCommands/options/number.ts	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 24bfcd7...e27d446. Read the comment docs.

kyranet commented 2 years ago

This needs a rebase.

milanmdev commented 2 years ago

Looks like the feature has been pushed to prod now.

Mysterious-Dev commented 2 years ago

This PR is dead ?

discordjs / builders

feat: add max/min option for int and number builder options #47

Codecov Report