discordjs / builders

A collection of builders that you can use when creating your bot.
Apache License 2.0
97 stars 37 forks source link

feat(*): replace ow with joi #56

Closed KhafraDev closed 2 years ago

KhafraDev commented 2 years ago

Please describe the changes this PR makes and why it should be merged:

Finally fixes #54 (ow hasn't supported ESM in at least 6 months, it likely never did). To fix ESM, the package author is planning on moving to ESM only, which in turn will break cjs users (they can still use dynamic imports but it's a pretty terrible solution, plus I don't know if the minifier would recognize this and minify accordingly?). So the option was to alienate esm users, or alienate cjs. The best solution I could think of was to just ditch ow.

Another solution would be to remove validation entirely because Discord's documentation is good enough as a reference for users to use instead. Or someone could roll back changes between v0.7.0 and 0.8.x that causes ow to get used in SlashCommandBuilder?

Another user experiencing the same issue.

Status and versioning classification: