discordjs / builders

A collection of builders that you can use when creating your bot.
Apache License 2.0
97 stars 37 forks source link

feat(SlashCommands): add attachment option #65

Open amitojsingh366 opened 2 years ago

amitojsingh366 commented 2 years ago

Please describe the changes this PR makes and why it should be merged: This PR adds the ability to add an attachment option to slash commands

Status and versioning classification: This PR relies on https://github.com/discordjs/discord-api-types/pull/272 and https://github.com/discord/discord-api-docs/pull/4253

NOTE: this is my first time contributing to this project so if anything is wrong please do tell me

codecov-commenter commented 2 years ago

Codecov Report

Merging #65 (ebfb69d) into main (0263f00) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        22    +1     
  Lines          276       279    +3     
  Branches        37        37           
=========================================
+ Hits           276       279    +3     
Impacted Files Coverage Δ
...nteractions/slashCommands/mixins/CommandOptions.ts 100.00% <100.00%> (ø)
...c/interactions/slashCommands/options/attachment.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0263f00...ebfb69d. Read the comment docs.

amitojsingh366 commented 2 years ago

the workflow will error on this PR until https://github.com/discordjs/discord-api-types/pull/272 is merged