discordjs / builders

A collection of builders that you can use when creating your bot.
Apache License 2.0
97 stars 37 forks source link

fix(ApplicationCommandOptions): ensure toJSON return is valid #69

Closed vladfrangu closed 2 years ago

vladfrangu commented 2 years ago

Please describe the changes this PR makes and why it should be merged:

Small mistake in number options made max and minValues to not get properly passed to api snake_case properties. This PR fixes that and also adds tests t

Status and versioning classification:

codecov-commenter commented 2 years ago

Codecov Report

Merging #69 (695a88d) into main (481e1f8) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #69   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          306       306           
  Branches        42        42           
=========================================
  Hits           306       306           
Impacted Files Coverage Δ
...actions/slashCommands/mixins/NameAndDescription.ts 100.00% <ø> (ø)
src/interactions/slashCommands/options/integer.ts 100.00% <100.00%> (ø)
src/interactions/slashCommands/options/number.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 481e1f8...695a88d. Read the comment docs.