discordjs / discord.js-modules

Modularisation of discord.js (WIP)
Apache License 2.0
192 stars 30 forks source link

feat(RequestManager): support setting global headers in options #70

Closed ckohen closed 3 years ago

ckohen commented 3 years ago

Please describe the changes this PR makes and why it should be merged:

Back on the horse trying to catch up /rest to what exists in the main lib.

This PR ports the logic from

Status and versioning classification:

codecov[bot] commented 3 years ago

Codecov Report

Merging #70 (601e809) into main (65cb8e2) will increase coverage by 0.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   85.84%   85.93%   +0.09%     
==========================================
  Files           8        8              
  Lines        1010     1017       +7     
  Branches      101      101              
==========================================
+ Hits          867      874       +7     
  Misses         42       42              
  Partials      101      101              
Impacted Files Coverage Δ
packages/rest/src/lib/REST.ts 95.58% <100.00%> (+0.12%) :arrow_up:
packages/rest/src/lib/RequestManager.ts 82.72% <100.00%> (+0.05%) :arrow_up:
packages/rest/src/lib/utils/constants.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65cb8e2...601e809. Read the comment docs.